mistercrunch commented on code in PR #34193:
URL: https://github.com/apache/superset/pull/34193#discussion_r2211948598
##########
superset-frontend/src/dashboard/components/Header/index.jsx:
##########
@@ -415,7 +415,9 @@ const Header = () => {
owners: dashboardInfo.owners,
roles: dashboardInfo.roles,
slug,
- tags: dashboardInfo.tags,
+ tags: (dashboardInfo.tags || []).filter(
+ item => item.type === 1 || !item.type,
Review Comment:
found it on the backend ->
https://github.com/apache/superset/blob/master/superset/tags/models.py#L61-L77
but couldn't find it on the frontend. Maybe we need a corresponding enum on the
frontend if we don't have one already ... hoping we don't hard-code meaningless
values related to TagType in other places in the frontend...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
