plavacquery opened a new pull request, #34204:
URL: https://github.com/apache/superset/pull/34204

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   This PR introduces support for OpenStreetMap as the tile provider behind 
deckgl charts. It also changes the default tile-provider to be OpenStreetMap, 
since Mapbox isn't as open and requires configuration + an API key.  This PR 
makes tile-providers configurable, so it's possible for those who have an API 
key and prefer Mapbox to match the default as of before-this-PR.
   
   Changing defaults here is a "breaking change" in the sense that the default 
is changing, but you can reproduce the previous behavior with a bit of 
documented configuration.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
![image](https://github.com/user-attachments/assets/2a39c6dd-084d-41e6-b542-961ad1be6a39)
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   In config.py set the following
   ```py
   DECKGL_BASE_MAP = [
        ['tile://https://c.tile.openstreetmap.org/{z}/{x}/{y}.png', 
'OpenStreetMap' ],
   ]
   
   ENABLE_CORS = True
   CORS_OPTIONS: dict[Any, Any] = {
       "origins": [
           "https://c.tile.openstreetmap.org";,
       ]
   }
   
   ```
   And in TALISMAN_DEV_CONF
   add "https://c.tile.openstreetmap.org"; to 'connect-src' array
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue 
:https://github.com/apache/superset/discussions/27475. Fixes 
https://github.com/apache/superset/issues/30763
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to