dosubot[bot] commented on issue #34214: URL: https://github.com/apache/superset/issues/34214#issuecomment-3085292196
<!-- Answer --> This regression is likely due to recent theming changes: Superset now uses Ant Design v5's token-based theming and dynamic dark mode, but the ECharts plugin isn't always applying theme tokens for axis label and text color in a way that updates reactively with theme changes. In particular, axis label color is not always set explicitly from the current theme, so when you switch to dark mode, labels can remain dark and become invisible against the background. The relevant code is in the Echart.tsx and transformProps.ts files, where theme tokens like colorText and colorTextSecondary should be used for axisLabel.color and textStyle.color, but in some chart types this isn't handled or is based on a static theme snapshot rather than the live context [[source]](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx). There isn't any documentation on customizing theme tokens specifically for this, but you can try setting THEME_DARK in your superset_config.py to ensure the dark algorithm is used, or use the theme editor (if enabled) to tweak color tokens. For a code fix, updating the ECharts plugin to always set axisLabel.color and textStyle.color from the live theme context (using useTheme) should resolve the issue. This is a new regression and representative of a broader architectural gap in theme token propagation [[source]](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/plugins/plugin-chart-echarts/src/Gantt/transformProps.ts). If you want to try a local fix or need pointers to the relevant code, let me know! <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/524e59a6-5bad-44f3-9597-5d5b2af4d98b?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/524e59a6-5bad-44f3-9597-5d5b2af4d98b?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/524e59a6-5bad-44f3-9597-5d5b2af4d98b?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/524e59a6-5bad-44f3-9597-5d5b2af4d98b?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/524e59a6-5bad-44f3-9597-5d5b2af4d98b?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/524e59a6-5bad-44f3-9597-5d5b2af4d98b?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/524e59a6-5bad-44f3-9597-5d5b2af4d98b?feedback_type=other)</sup> [](https://go.dosu.dev/discord-bot) [! [Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/34214) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
