amaannawab923 commented on code in PR #34175:
URL: https://github.com/apache/superset/pull/34175#discussion_r2215792208
##########
superset-frontend/packages/superset-ui-core/src/chart/registries/ChartBuildQueryRegistrySingleton.ts:
##########
@@ -19,12 +19,12 @@
import {
Registry,
- makeSingleton,
OverwritePolicy,
QueryContext,
SetDataMaskHook,
JsonObject,
} from '../..';
+import makeSingleton from '../../utils/makeSingleton';
Review Comment:
Please revert this as its unrelated to the pr
##########
superset-frontend/packages/superset-ui-core/src/chart/models/ChartProps.ts:
##########
@@ -25,11 +25,11 @@ import { createSelector } from 'reselect';
import {
AppSection,
Behavior,
- convertKeysToCamelCase,
Datasource,
FilterState,
JsonObject,
} from '../..';
+import convertKeysToCamelCase from '../../utils/convertKeysToCamelCase';
Review Comment:
Please revert this as its unrelated to the pr
##########
superset-frontend/packages/superset-ui-core/src/query/getClientErrorObject.ts:
##########
@@ -20,12 +20,12 @@ import {
COMMON_ERR_MESSAGES,
JsonObject,
SupersetClientResponse,
- t,
SupersetError,
- ErrorTypeEnum,
- isProbablyHTML,
- isJsonString,
} from '@superset-ui/core';
+import isJsonString from '../utils/isJsonString';
Review Comment:
Please revert this as its unrelated to the pr
##########
superset-frontend/packages/superset-ui-core/src/query/getXAxis.ts:
##########
@@ -19,11 +19,11 @@
import {
DTTM_ALIAS,
getColumnLabel,
- isQueryFormColumn,
QueryFormData,
QueryFormColumn,
Optional,
} from '@superset-ui/core';
+import { isQueryFormColumn } from './types/Column';
Review Comment:
Please revert this as its unrelated to the pr
##########
superset-frontend/packages/superset-ui-core/src/utils/index.ts:
##########
@@ -20,6 +20,7 @@ export { default as convertKeysToCamelCase } from
'./convertKeysToCamelCase';
export { default as ensureIsArray } from './ensureIsArray';
export { default as ensureIsInt } from './ensureIsInt';
export { default as isDefined } from './isDefined';
+export { default as isJsonString } from './isJsonString';
Review Comment:
Please remove the isJsonString util as i dont see it being used as per the
description of pr
##########
superset-frontend/packages/superset-ui-core/src/color/LabelsColorMapSingleton.ts:
##########
@@ -17,7 +17,7 @@
* under the License.
*/
-import { makeSingleton } from '../utils';
+import makeSingleton from '../utils/makeSingleton';
Review Comment:
Please revert this as its unrelated to the pr
##########
superset-frontend/packages/superset-ui-core/src/chart/registries/ChartComponentRegistrySingleton.ts:
##########
@@ -17,7 +17,8 @@
* under the License.
*/
-import { Registry, makeSingleton, OverwritePolicy } from '../..';
+import { Registry, OverwritePolicy } from '../..';
+import makeSingleton from '../../utils/makeSingleton';
Review Comment:
Please revert this as its unrelated to the pr
##########
superset-frontend/packages/superset-ui-core/src/chart/registries/ChartMetadataRegistrySingleton.ts:
##########
@@ -17,7 +17,8 @@
* under the License.
*/
-import { Registry, makeSingleton, OverwritePolicy } from '../..';
+import { Registry, OverwritePolicy } from '../..';
+import makeSingleton from '../../utils/makeSingleton';
Review Comment:
Please revert this as its unrelated to the pr
##########
superset-frontend/packages/superset-ui-core/src/chart/registries/ChartControlPanelRegistrySingleton.ts:
##########
@@ -17,7 +17,8 @@
* under the License.
*/
-import { Registry, makeSingleton } from '../..';
+import { Registry } from '../..';
+import makeSingleton from '../../utils/makeSingleton';
Review Comment:
Please revert this as its unrelated to the pr
##########
superset-frontend/packages/superset-ui-core/src/number-format/NumberFormatterRegistrySingleton.ts:
##########
@@ -17,7 +17,7 @@
* under the License.
*/
import { FormatLocaleDefinition } from 'd3-format';
-import { makeSingleton } from '../utils';
+import makeSingleton from '../utils/makeSingleton';
Review Comment:
Please revert this as its unrelated to the pr
##########
superset-frontend/packages/superset-ui-core/src/chart/registries/ChartTransformPropsRegistrySingleton.ts:
##########
@@ -17,7 +17,8 @@
* under the License.
*/
-import { Registry, makeSingleton, OverwritePolicy } from '../..';
+import { Registry, OverwritePolicy } from '../..';
+import makeSingleton from '../../utils/makeSingleton';
Review Comment:
Please revert this as its unrelated to the pr
##########
superset-frontend/packages/superset-ui-core/src/time-format/TimeFormatterRegistrySingleton.ts:
##########
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { makeSingleton } from '../utils';
+import makeSingleton from '../utils/makeSingleton';
Review Comment:
Please revert this as its unrelated to the pr
##########
superset-frontend/packages/superset-ui-core/src/utils/isJsonString.ts:
##########
@@ -0,0 +1,36 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/**
+ * Checks if a string is valid JSON
+ * @param str - The string to check
Review Comment:
Is it being used anywhere in context of the pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
