mistercrunch commented on code in PR #34182:
URL: https://github.com/apache/superset/pull/34182#discussion_r2220865096
##########
superset-frontend/src/dashboard/containers/DashboardPage.tsx:
##########
@@ -215,6 +222,34 @@ export const DashboardPage: FC<PageProps> = ({ idOrSlug }:
PageProps) => {
return () => {};
}, [css]);
+ // Apply dashboard theme when dashboard loads
+ useEffect(() => {
+ const applyDashboardTheme = async () => {
+ if (dashboard?.theme?.id) {
Review Comment:
Good catch. For now I may just prevent deletion for themes attached to
dashboards or dissociate on theme delete, gotta decide what to do .... TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
