mistercrunch commented on PR #34272: URL: https://github.com/apache/superset/pull/34272#issuecomment-3109940790
> @mistercrunch how did you encounter the build issue? I'm currently running latest master with changs in PR being uncommented but unable to reproduce it :( oh now you're making me doubt whether my issues could have been local (?) Clearly there's some things that happened recently that didn't play nice with the frontend build cache. Or maybe your environment is ok because of some caching. Now thinking that if I had time, I'd start clean with a new cloned repo and see if my issues can be reproduced prior to this PR. What I'd do (or might do if I can find the time...): - start super fresh, git clone in a new folder (no cache!) as of the SHA right before this commit here got merged on `master` - nuke database - nuke npm cache, any other cache ... - `docker compose up`, see if things build or if we see any build-related issues - if no issues, revert this PR ... - if there are issues, try as of after this PR to see if my PR indeed fixes issues Now after this fix or sometime yesterday, I did discover I had a zombie `npm run dev` process that was causing havoc. This whole saga could be related to that, but I'm unclear on that... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
