Vitor-Avila opened a new pull request, #34293:
URL: https://github.com/apache/superset/pull/34293

   ### SUMMARY
   The **View query** modal was always showing a **View in SQL Lab** button, 
regardless if the user has access to SQL Lab. This PR hides the button in case 
the user does not have access to it.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <img width="893" height="742" alt="image" 
src="https://github.com/user-attachments/assets/ba738de8-441d-45a0-b424-53690c4455b7";
 />
   
   ### TESTING INSTRUCTIONS
   Frontend test added. For manual testing:
   1. Create a test account that does not have the `menu access on SQL Lab` 
permission.
   2. Open a dashboard and click on the chart ellipses > **View query**.
   3. Validate the modal loads up properly but the **View in SQL Lab button** 
is not displayed.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to