fardin-developer opened a new pull request, #34298: URL: https://github.com/apache/superset/pull/34298
Fixes: #34030 ### Repro steps: **Create a mixed chart** 1. In one of the queries, set the metric to use a number. In the other, set it to use a % 2. In the Customize tab, set the Primary y-axis format and Secondary y-axis format. One should use something numeric and the other should use something with a % 3. Hover over the tooltips on the chart  ### SUMMARY Fixed a bug in mixed charts where tooltips were displaying primary axis values with secondary axis formatting. When Query A used numeric formatting (e.g., `",d"`) and Query B used percentage formatting (e.g., `",.1%"`), tooltips would incorrectly show primary axis values like `4724163` as `472416260.0%`. **Root Cause:** The tooltip formatter had two critical issues: 1. **Series identification failure**: `primarySeries.has(key)` always returned `false` because tooltip keys included "(Query A/B)" suffixes but series sets only contained base metric names 2. **Wrong formatter selection**: Due to the failed check, all tooltips defaulted to using the secondary axis formatter **Solution:** Updated the tooltip formatter to identify series by checking for "(Query B)" in the tooltip key name, ensuring each query uses its correct y-axis format. ## BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### Before (Buggy Behavior): <img width="1147" height="618" alt="Screenshot 2025-07-24 at 1 00 22 PM" src="https://github.com/user-attachments/assets/e527afc8-3a31-499b-a138-b889cef8e56d"; /> <br> ### After (Fixed Behavior): Hovering over Query A data point shows: `SUM(sales): 1,029,838` (correct numeric) Hovering over Query B data point shows: `COUNT(*): 29,600.0%` (correct %) <img width="1171" height="712" alt="Screenshot 2025-07-24 at 12 54 16 PM" src="https://github.com/user-attachments/assets/0046f9ce-152a-47b2-bd0a-c0b507edf1c8"; /> ### TESTING INSTRUCTIONS 1. Create a mixed chart with two queries 2. Set different formats for each query: - Query A: Numeric metric with primary y-axis format `",d"` - Query B: Any metric with secondary y-axis format `",.1%"` 3. Hover over data points from both queries 5. Verify tooltips display correct formatting: - Query A tooltips use primary y-axis format (numeric) - Query B tooltips use secondary y-axis format (percentage) 6. Test with various format combinations (currency, percentage, scientific notation) ### ADDITIONAL INFORMATION - [x] Has associated issue: Fixes #34030 - [ ] Required feature flags: - [x] Changes UI (tooltip display formatting) - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API **Files Modified:** - `superset-frontend/src/visualizations/plugins/plugin-chart-echarts/MixedTimeseries/transformProps.ts` **Technical Details:** - **Old logic**: `primarySeries.has(key)` check failed because series sets contained `['SUM(sales)']` but tooltip keys were `'SUM(sales) (Query A)'` - **New logic**: `key.includes('(Query B)')` correctly identifies secondary series - **Impact**: Ensures proper formatter selection without breaking existing functionality -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
