gabotorresruiz commented on code in PR #34273:
URL: https://github.com/apache/superset/pull/34273#discussion_r2228782091
##########
superset-frontend/src/theme/ThemeController.ts:
##########
@@ -115,14 +123,14 @@ export class ThemeController {
bootstrapDefaultTheme,
bootstrapDarkTheme,
bootstrapThemeSettings,
- hasBootstrapThemes,
+ hasCustomThemes,
Review Comment:
It feels more natural to say that it `hasCustomThemes` that also applies
when passing custom theme from the embedded SDK than only `hasBootstrapThemes`
when actually you're not passing bootstrap data from embedded SDK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
