LevisNgigi commented on PR #34296: URL: https://github.com/apache/superset/pull/34296#issuecomment-3114238901
> The two queries were identical, and from my understanding aggregations for everything but `None` were done client-side. Is that what we intended? Is this PR right for sure? Aggregations for everything was done server-side but for none we would just skip the aggregation similar to last value? I agree with the duplicate query issue though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
