mistercrunch commented on code in PR #34182: URL: https://github.com/apache/superset/pull/34182#discussion_r2229160704
########## superset-frontend/src/features/themes/ThemeModal.tsx: ########## @@ -0,0 +1,394 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { FunctionComponent, useState, useEffect, ChangeEvent } from 'react'; + +import { css, styled, t, useTheme } from '@superset-ui/core'; +import { useSingleViewResource } from 'src/views/CRUD/hooks'; +import { useThemeContext } from 'src/theme/ThemeProvider'; + +import { Icons } from '@superset-ui/core/components/Icons'; +import withToasts from 'src/components/MessageToasts/withToasts'; +import { + Input, + Modal, + JsonEditor, + Button, + Form, + Tooltip, + Alert, +} from '@superset-ui/core/components'; +import { Typography } from '@superset-ui/core/components/Typography'; + +import { OnlyKeyWithType } from 'src/utils/types'; +import { ThemeObject } from './types'; + +interface ThemeModalProps { + addDangerToast: (msg: string) => void; + addSuccessToast?: (msg: string) => void; + theme?: ThemeObject | null; + onThemeAdd?: (theme?: ThemeObject) => void; + onHide: () => void; + show: boolean; + canDevelop?: boolean; +} + +type ThemeStringKeys = keyof Pick< + ThemeObject, + OnlyKeyWithType<ThemeObject, String> +>; + +const StyledJsonEditor = styled.div` + ${({ theme }) => css` + border-radius: ${theme.borderRadius}px; + border: 1px solid ${theme.colorBorder}; + + .ace_editor { + border-radius: ${theme.borderRadius}px; + } + `} +`; + +const ThemeModal: FunctionComponent<ThemeModalProps> = ({ + addDangerToast, + addSuccessToast, + onThemeAdd, + onHide, + show, + theme = null, + canDevelop = false, +}) => { + const supersetTheme = useTheme(); + const { setTemporaryTheme } = useThemeContext(); + const [disableSave, setDisableSave] = useState<boolean>(true); + const [currentTheme, setCurrentTheme] = useState<ThemeObject | null>(null); + const [isHidden, setIsHidden] = useState<boolean>(true); + const isEditMode = theme !== null; + const isSystemTheme = currentTheme?.is_system === true; + const isReadOnly = isSystemTheme; + const canDevelopThemes = canDevelop; + + // theme fetch logic + const { + state: { loading, resource }, + fetchResource, + createResource, + updateResource, + } = useSingleViewResource<ThemeObject>('theme', t('theme'), addDangerToast); + + // Functions + const hide = () => { + onHide(); + setCurrentTheme(null); + }; + + const onSave = () => { + if (isEditMode) { + // Edit + if (currentTheme?.id) { + const update_id = currentTheme.id; + delete currentTheme.id; + delete currentTheme.created_by; + delete currentTheme.changed_by; + delete currentTheme.changed_on_delta_humanized; + + updateResource(update_id, currentTheme).then(response => { + if (!response) { + return; + } + + if (onThemeAdd) { + onThemeAdd(); + } + + hide(); + }); + } + } else if (currentTheme) { + // Create + createResource(currentTheme).then(response => { + if (!response) { + return; + } + + if (onThemeAdd) { + onThemeAdd(); + } + + hide(); + }); + } + }; + + const onApply = () => { + if (currentTheme?.json_data && isValidJson(currentTheme.json_data)) { + try { + const themeConfig = JSON.parse(currentTheme.json_data); + setTemporaryTheme(themeConfig); + if (addSuccessToast) { + addSuccessToast(t('Local theme set for preview')); + } + } catch (error) { + addDangerToast(t('Failed to apply theme: Invalid JSON')); + } + } + }; + + const onThemeNameChange = (event: ChangeEvent<HTMLInputElement>) => { + const { target } = event; + + const data = { + ...currentTheme, + theme_name: currentTheme ? currentTheme.theme_name : '', + json_data: currentTheme ? currentTheme.json_data : '', + }; + + data[target.name as ThemeStringKeys] = target.value; + setCurrentTheme(data); + }; + + const onJsonDataChange = (jsonData: string) => { + const data = { + ...currentTheme, + theme_name: currentTheme ? currentTheme.theme_name : '', + json_data: jsonData, + }; + setCurrentTheme(data); + }; + + const isValidJson = (str?: string) => { + if (!str) return false; + try { + JSON.parse(str); + return true; + } catch (e) { + return false; + } + }; + + const validate = () => { + if (isReadOnly) { + setDisableSave(true); + return; + } + + if ( + currentTheme?.theme_name.length && + currentTheme?.json_data?.length && + isValidJson(currentTheme.json_data) + ) { + setDisableSave(false); + } else { + setDisableSave(true); + } + }; + + // Initialize + useEffect(() => { + if ( + isEditMode && + (!currentTheme?.id || + (theme && theme?.id !== currentTheme.id) || + (isHidden && show)) + ) { + if (theme?.id && !loading) { + fetchResource(theme.id); + } + } else if ( + !isEditMode && + (!currentTheme || currentTheme.id || (isHidden && show)) + ) { + setCurrentTheme({ + theme_name: '', + json_data: JSON.stringify({}, null, 2), + }); + } + }, [theme, show]); + + useEffect(() => { + if (resource) { + setCurrentTheme(resource); + } + }, [resource]); + + // Validation + useEffect(() => { + validate(); + }, [ + currentTheme ? currentTheme.theme_name : '', + currentTheme ? currentTheme.json_data : '', + isReadOnly, + ]); + + // Show/hide + if (isHidden && show) { + setIsHidden(false); + } + + return ( + <Modal + disablePrimaryButton={isReadOnly || disableSave} + onHandledPrimaryAction={isReadOnly ? undefined : onSave} + onHide={hide} + primaryButtonName={isEditMode ? t('Save') : t('Add')} + show={show} + width="55%" + footer={[ + <Button key="cancel" onClick={hide} buttonStyle="secondary"> + {isReadOnly ? t('Close') : t('Cancel')} + </Button>, + ...(!isReadOnly + ? [ + <Button + key="save" + onClick={onSave} + disabled={disableSave} + buttonStyle="primary" + > + {isEditMode ? t('Save') : t('Add')} + </Button>, + ] + : []), + ]} + title={ + <Typography.Title level={4} data-test="theme-modal-title"> + {isEditMode ? ( + <Icons.EditOutlined + iconSize="l" + css={css` + margin: auto ${supersetTheme.sizeUnit * 2}px auto 0; + `} + /> + ) : ( + <Icons.PlusOutlined + iconSize="l" + css={css` + margin: auto ${supersetTheme.sizeUnit * 2}px auto 0; + `} + /> + )} + {isEditMode + ? isReadOnly + ? t('View theme properties') + : t('Edit theme properties') + : t('Add theme')} + </Typography.Title> + } + > + <Form layout="vertical"> + {isSystemTheme && ( + <Typography.Text + type="secondary" + style={{ + fontSize: '14px', + fontStyle: 'italic', + marginBottom: '16px', Review Comment: good catch ... let me fix the whole form -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
