imcewen02 opened a new pull request, #34311:
URL: https://github.com/apache/superset/pull/34311

   ### SUMMARY
   Fixes: https://github.com/apache/superset/issues/34310. 
   It seems that the recent UI updates messed up the styling for pagination of 
the table chart. I've tried to redesign the dt-pagination to match the style of 
other elements as well as the dt-pagination style as seen in 4.1.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   <img width="1907" height="918" alt="image" 
src="https://github.com/user-attachments/assets/e2caabee-c453-44cb-8171-8902b8dc5f2b";
 />
   
   After: 
   <img width="1905" height="914" alt="image" 
src="https://github.com/user-attachments/assets/b16fa1a6-18c4-44db-a02e-10a85e85b39f";
 />
   
   ### TESTING INSTRUCTIONS
   1: Create a new chart of type "Table", with any dataset
   2: Add any column so that the chart can be generated
   3: Change the page length such that the pagination footer is generated and 
verify the new styling has taken effect
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: https://github.com/apache/superset/issues/34310
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to