LisaHusband commented on issue #32835: URL: https://github.com/apache/superset/issues/32835#issuecomment-3119086071
When the metric in the waterfall chart differs from the metrics used in the line chart, no duplication or increase occurs. Generally speaking, when switching between the waterfall chart and the line chart, metric changes will only focus on the first metric — this happens after applying the changes in my PR. And I believe it should be this way, because we only pass the first metric to the waterfall chart (as it is restricted to accept only one metric). Given the current design philosophy — where metric and other form data are globally shared — I believe this is the best approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
