amaannawab923 commented on code in PR #33831:
URL: https://github.com/apache/superset/pull/33831#discussion_r2239765549
##########
superset-frontend/src/dashboard/actions/hydrate.js:
##########
@@ -244,6 +245,11 @@ export const hydrateDashboard =
metadata.cross_filters_enabled,
);
+ const chartCustomizationItems = metadata?.chart_customization_config || [];
+ if (chartCustomizationItems.length > 0) {
+ dispatch(initializeChartCustomization(chartCustomizationItems));
+ }
+
Review Comment:
The work of hydrate is to initialise , You can use the HYDRATE_DASHBOARD
action directly in your reducer ... What you have wrote might work ... But we
do not dispatch extra actions in Hydrate of dashboard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
