dosubot[bot] commented on issue #34402: URL: https://github.com/apache/superset/issues/34402#issuecomment-3136037859
<!-- Answer --> You're right—column labels (verbose_name) from the dataset editor aren't consistently shown in the "Drill to detail" and "Drill to detail by" menus. The menus are implemented in the frontend, mainly in `DrillDetailMenuItems.tsx` and `ChartContextMenu.tsx`. While the "Drill by" menu already uses the label if available, the "Drill to detail by" submenu currently displays `filter.formattedVal`, which may just be the column name, not the label. Superset has utilities like `useVerboseMap` and `columnChoices` that map column names to labels, but not all components use them. To make the drill menus consistent with charts and downloads, update the relevant menu components to resolve and display the column label (verbose_name) when it exists, falling back to the column name otherwise. Centralizing this logic (for example, always using `useVerboseMap`) would help maintain consistency across the UI. No existing tickets or docs cover this specific issue, so this would be a new improvement for the frontend codebase. For reference, see the current implementations in [`DrillDetailMenuItems.tsx`](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/components/Chart/DrillDetail/DrillDetailMenuItems.tsx), [`ChartContextMenu.tsx`](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.tsx), and the label mapping utility [`useVerboseMap`](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/hooks/apiResources/datasets.ts). <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/bdb98b79-863f-4030-ae3d-6331a95f7ef1?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/bdb98b79-863f-4030-ae3d-6331a95f7ef1?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/bdb98b79-863f-4030-ae3d-6331a95f7ef1?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/bdb98b79-863f-4030-ae3d-6331a95f7ef1?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/bdb98b79-863f-4030-ae3d-6331a95f7ef1?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/bdb98b79-863f-4030-ae3d-6331a95f7ef1?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/bdb98b79-863f-4030-ae3d-6331a95f7ef1?feedback_type=other)</sup> [](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=githu b) [](https://go.dosu.dev/discord-bot) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/34402) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
