mistercrunch commented on code in PR #34412:
URL: https://github.com/apache/superset/pull/34412#discussion_r2243893297
##########
superset/sql/parse.py:
##########
@@ -654,6 +654,16 @@ def is_mutating(self) -> bool:
if isinstance(self._parsed, exp.Command) and self._parsed.name ==
"ALTER":
return True # pragma: no cover
+ if (
Review Comment:
should this be a super simple method in `db_engine_spec` that's a no-op in
base and something different for PG?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
