trentontrees opened a new pull request, #34418:
URL: https://github.com/apache/superset/pull/34418

   This is merging changes from #26239 into a fresh apache/superset>master.  At 
this time, no alterations were made to @chanduapple code.
   
   ### SUMMARY
   updated the utils.py to update the chart id references for cross filter 
scoping also. currently chart id reference updates is present for native 
filters, position and few others, but not for cross filter scoping.
   
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   see #26239
   
   ### TESTING INSTRUCTIONS
   1. create dashboard with cross filter scoping.
   2. export the dashboard.
   3. delete the dashboard and charts used in dashboards.
   4. import the dashboard
   5. check the cross filter scoping
   
   ### ADDITIONAL INFORMATION
   Fixes "#19944"
   
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #19944 
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to