rusackas opened a new pull request, #34523: URL: https://github.com/apache/superset/pull/34523
### SUMMARY Fixes issue #34141 where conditional formatting color scheme options for "Green for increase, red for decrease" and "Red for increase, green for decrease" were showing in table charts even when no time comparison was active. These color options only work with time comparison data, so they should be hidden when time_compare is empty. The fix modifies both table chart control panels to dynamically show/hide these color options based on whether time comparison is enabled. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **Before:** Color scheme options "Green for increase, red for decrease" and "Red for increase, green for decrease" appeared in conditional formatting dropdowns even without time comparison enabled. **After:** These color scheme options only appear when time comparison is active (time_compare has a value). ### TESTING INSTRUCTIONS 1. Create a new table chart without time comparison enabled 2. Go to Visual formatting -> Custom conditional formatting 3. Create a new conditional formatting rule 4. Check the color scheme dropdown - should NOT see "Green for increase, red for decrease" options 5. Enable time comparison in the chart configuration 6. Return to conditional formatting - should now see the increase/decrease color options ### ADDITIONAL INFORMATION - [x] Has associated issue: Fixes #34141 - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
