mistercrunch commented on PR #34526: URL: https://github.com/apache/superset/pull/34526#issuecomment-3149039977
The feature is super neat, very dynamic, charts show up instantly as you pick metrics and/or dimension members. At first I though it was going to be super messy architecturally (lots of special cases between Explore, Dashboard and embedded), but by building the feature in `<SuperChart />` (clean foundation for all charts in Superset), and creating a new, simple `<StatelessChart />` wrapper around it (lands in `@superset-ui`, receives either `formData` or simply a `chartId`), the code is super clean, and `Matrixify` becomes a core, foundational feature deeply baked into Superset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
