mistercrunch commented on PR #34510: URL: https://github.com/apache/superset/pull/34510#issuecomment-3152855222
Maybe we put this on hold in favor of a pick your system themes UI feature. My analysis on it: - add a new key in `THEME_SETTINGS`, something like `ALLOW_ADMINS_TO_SET_SYSTEM_THEMES_IN_UI = False` - add new bool fields to the `ThemeModel` -> `is_system_default` + `is_system_dark` - add a UI feature to "set as system default(light)", "set as system default(dark)", could be in list view or whatever makes sense here, maybe as sun/moon icon, add a REST endpoint for it. Only Admins can hit it. - add a `Command` to set theme as system theme `set_as_system_theme_default(theme_uuid)` and `set_as_system_theme_dark(theme_uuid)`, that insures one-and-only-one theme can have the fields `is_system_default` and `is_system_dark` as True - change the logic in bootstrap data/init to handle theme fetching based on `ALLOW_ADMINS_TO_SET_SYSTEM_THEMES_IN_UI` and falls back on the right `is_system=True` themes if/when a system UI theme is deleted. - OR, prevent the deletion of themes where is_system_default=True or is_system_dark=True Something like that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
