justinpark opened a new pull request, #34556:
URL: https://github.com/apache/superset/pull/34556

   ### SUMMARY
   If a bigint value is mixed in the middle of the raw table data, there was an 
issue because the logic for calculating the current value range only checked 
the first row for a number and then computed the max value based on that.
   As a result, an error occurred when bigint values appeared in the middle of 
the data. This commit fixes the issue by modifying the logic so that the value 
range is only calculated when all rows are numbers.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   
   <img width="604" height="742" alt="Screenshot_2025-08-05_at_9_29_36 AM" 
src="https://github.com/user-attachments/assets/145cc6b6-bbd2-4af2-b2b8-6fccbe8b6658";
 />
   
   
   After:
   
   <img width="615" height="542" alt="Screenshot_2025-08-05_at_9_29_09 AM" 
src="https://github.com/user-attachments/assets/f8435567-0af1-4586-aad1-b9fc3cb1b06d";
 />
   
   
   ### TESTING INSTRUCTIONS
   
   create a data containing a bigint in the second row
   Create a chart with the data and then the error is thrown
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to