rusackas commented on code in PR #33275:
URL: https://github.com/apache/superset/pull/33275#discussion_r2254981158
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/utilities.js:
##########
@@ -274,15 +274,9 @@ const baseAggregatorTemplates = {
this.val !== null ? this.val : coercedValue,
);
}
- } else if (
- mode === 'first' &&
- this.sorter(x, this.val !== null ? this.val : x) <= 0
- ) {
- this.val = x;
- } else if (
- mode === 'last' &&
- this.sorter(x, this.val !== null ? this.val : x) >= 0
- ) {
+ } else if (mode === 'first') {
+ this.val = this.val === null ? x : this.val;
Review Comment:
Curious your thoughts on this suggestion @ksnikiforov :) And thank you for
the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
