kgabryje commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2256348171
##########
superset/config.py:
##########
@@ -865,6 +865,14 @@ class D3TimeFormat(TypedDict, total=False):
timedelta(seconds=60).total_seconds() * 1000
)
+# Tiled screenshot configuration for large dashboards
+SCREENSHOT_TILED_ENABLED = True # Enable tiled screenshots for large
dashboards
+SCREENSHOT_TILED_CHART_THRESHOLD = 20 # Minimum charts to trigger tiled
screenshots
+SCREENSHOT_TILED_HEIGHT_THRESHOLD = (
Review Comment:
Yes it's for alerts/reports. We can set viewport width in report creation
modal, and height can be set in config.py.
This however is an optimization for large dashboards - if dashboard is
longer than `SCREENSHOT_TILED_HEIGHT_THRESHOLD`, then we use tiled screenshots.
Tiled screenshots mean that instead of screenshotting the entire dashboard
(i.e. the `.standalone` element), we screenshot only a fragment
(`SCREENSHOT_TILED_VIEWPORT_HEIGHT`) multiple times.
For example, if the dashboard has height 10000px, and
`SCREENSHOT_TILED_VIEWPORT_HEIGHT` is 3000, we take 3 3000px screenshots and 1
1000px screenshot and glue them together into 1 10000px image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
