Re: [PR] feat(Timeseries & MixedTimeseries): Force selected timegrain on timeseries intervals when the x-axis is of timestamp type [superset]

[via GitHub]

korbit-ai[bot] commented on code in PR #34595:
URL: https://github.com/apache/superset/pull/34595#discussion_r2259924886


##########
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts:
##########
@@ -574,11 +575,17 @@ export default function transformProps(
       },
       minorTick: { show: minorTicks },
       minInterval:
-        xAxisType === AxisType.Time && timeGrainSqla
+        xAxisType === AxisType.Time && timeGrainSqla && !forceMaxInterval
           ? TIMEGRAIN_TO_TIMESTAMP[
               timeGrainSqla as keyof typeof TIMEGRAIN_TO_TIMESTAMP
             ]
           : 0,
+      maxInterval:
+        xAxisType === 'time' && timeGrainSqla && forceMaxInterval

Review Comment:
   ### Inconsistent xAxisType Check <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The code uses a string literal 'time' to check xAxisType when earlier it 
uses the enum AxisType.Time
   
   
   ###### Why this matters
   This inconsistency could cause the maxInterval logic to never execute if the 
xAxisType is set using the enum, leading to the forceMaxInterval feature not 
working as intended.
   
   ###### Suggested change ∙ *Feature Preview*
   Replace the string literal check with the enum check to maintain consistency:
   ```typescript
   maxInterval:
           xAxisType === AxisType.Time && timeGrainSqla && forceMaxInterval
             ? TIMEGRAIN_TO_TIMESTAMP[
                 timeGrainSqla as keyof typeof TIMEGRAIN_TO_TIMESTAMP
               ]
             : undefined,
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/37bd13f3-3240-4417-966f-4e2c46837900/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/37bd13f3-3240-4417-966f-4e2c46837900?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/37bd13f3-3240-4417-966f-4e2c46837900?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/37bd13f3-3240-4417-966f-4e2c46837900?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/37bd13f3-3240-4417-966f-4e2c46837900)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:58d1f800-80ec-456b-93e2-0447801930e0 -->
   
   
   [](58d1f800-80ec-456b-93e2-0447801930e0)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org