mistercrunch commented on code in PR #34560:
URL: https://github.com/apache/superset/pull/34560#discussion_r2265616513
##########
docs/docs/configuration/theming.mdx:
##########
@@ -62,12 +62,13 @@ THEME_DARK = {
}
}
-# Theme behavior settings
-THEME_SETTINGS = {
- "enforced": False, # If True, forces default theme always
- "allowSwitching": True, # Allow users to switch between themes
- "allowOSPreference": True, # Auto-detect system theme preference
-}
+# Enable UI-based theme administration for admins
+ENABLE_UI_THEME_ADMINISTRATION = True
+
+# To force a single theme on all users, set THEME_DARK = None
+# When both THEME_DEFAULT and THEME_DARK are defined:
+# - Users can manually switch between themes
+# - OS preference detection is automatically enabled
Review Comment:
A simple thing to imagine is that they would have their own mode picker in
the host app (light/dark/use-os), in which case they hold the state and have to
manage their own logic as to how to couple the embedded dashboard's theme
fetching, and can't rely on our logic / picker to do the same thing. Seems that
logic of deciding which Superset-hosted theme to use belongs on their side and
is best managed as code as opposed to configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
