michael-s-molina commented on PR #34526: URL: https://github.com/apache/superset/pull/34526#issuecomment-3176705713
@mistercrunch I'll defer the code review and start with the feature itself as the review might impact the code. Some observations: - I think it would be better to hide the Top N feature and it's controls for now instead of displaying the 'Not implemented yet' tag with controls that won't work. - What do you think to moving the `Show row labels` and `Show column headers` to the Columns/Rows containers and make them appear only when there are dimension/metric values selected? Displaying an empty header when there's no value selected is kind of useless. This could also simplify the UI by removing the Matrix section. - Should we also match the style of chart titles with other charts? They don't have a background color and no bottom border. cc @kasiazjc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
