kasiazjc opened a new pull request, #34655:
URL: https://github.com/apache/superset/pull/34655

   ## SUMMARY
   <\!--- Describe the change below, including rationale and design decisions 
-->
   
   With the introduction of theming support, the "White" background option for 
chart panels is no longer accurate, as the actual background color may vary 
depending on the selected theme. This PR changes the user-facing label from 
"White" to "Solid" to provide a neutral, theme-agnostic description.
   
   ## BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <\!--- Skip this if not applicable -->
   
   **Before:** Background option shows "White"
   **After:** Background option shows "Solid"
   
   ## TESTING INSTRUCTIONS
   <\!--- Required\! What steps can be taken to manually verify the changes? -->
   
   1. Open a dashboard in edit mode
   2. Click on a chart to access chart panel settings
   3. Look for the background style dropdown
   4. Verify that the option now shows "Solid" instead of "White"
   5. Verify that the functionality remains the same (solid background is 
applied)
   
   ## ADDITIONAL INFORMATION
   <\!--- Check any relevant boxes with "x" -->
   <\!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   
   - [ ] Has associated issue:
   - [x] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   This change is related to ongoing theming improvements where color-specific 
labels need to be updated to be theme-neutral.
   
   🤖 Generated with [Claude Code](https://claude.ai/code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to