Antonio-RiveroMartnez commented on code in PR #34654: URL: https://github.com/apache/superset/pull/34654#discussion_r2270740880
########## superset/constants.py: ########## @@ -243,3 +243,7 @@ class CacheRegion(StrEnum): DEFAULT = "default" DATA = "data" THUMBNAIL = "thumbnail" + + +# Cache timeout constants +CACHE_NO_TIMEOUT = -1 # Special value indicating no caching should occur Review Comment: nit: rename to `CACHE_DISABLED_TIMEOUT` because the `NO_TIMEOUT` in my mind reads like "i's cached forever because it has no timeout" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org