rusackas commented on PR #31765: URL: https://github.com/apache/superset/pull/31765#issuecomment-3181061821
Some feedback from Claude: **Breaking Change Risk**: The convertKeysToCamelCase(formData.extraFormData) could be a breaking change if: Other components expect snake_case keys from extraFormData There are existing visualizations that rely on the current key format The conversion could cause naming conflicts **Format Override Behavior**: When timeGrain is QUARTER, MONTH, or YEAR, the code completely ignores the user-specified format and uses a default formatter. This might surprise users who expect their custom format to be applied. **Undefined Format Handling**: The code passes undefined as the format to getTimeFormatter for certain time grains, which needs verification that this is handled properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
