Re: [PR] fix: Avoid dataset drill request if no perm [superset]

Tue, 12 Aug 2025 21:08:11 -0700 


korbit-ai[bot] commented on code in PR #34665:
URL: https://github.com/apache/superset/pull/34665#discussion_r2272016686


##########
superset-frontend/src/hooks/apiResources/datasets.ts:
##########
@@ -71,6 +72,15 @@ export const useDatasetDrillInfo = (
   });
 
   useEffect(() => {
+    if (skip) {
+      // short circuit if `skip` is `true`
+      setResource({
+        status: ResourceStatus.Complete,
+        result: {} as Dataset,

Review Comment:
   ### Unsafe Type Casting of Empty Object <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Type casting an empty object to Dataset type can lead to runtime errors as 
the required properties of Dataset type are missing.
   
   
   ###### Why this matters
   Components consuming this hook expect a valid Dataset object with specific 
properties. When accessing these properties on an empty object, it may cause 
runtime errors even though TypeScript compilation succeeds.
   
   ###### Suggested change ∙ *Feature Preview*
   Return null as the result when skipping, or provide a minimal valid Dataset 
object with default values:
   ```typescript
   result: skip ? null : {
     columns: [],
     metrics: [],
     verbose_map: {},
   } as Dataset
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6fe43efb-2efa-4c4e-822c-537302483ef6/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6fe43efb-2efa-4c4e-822c-537302483ef6?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6fe43efb-2efa-4c4e-822c-537302483ef6?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6fe43efb-2efa-4c4e-822c-537302483ef6?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6fe43efb-2efa-4c4e-822c-537302483ef6)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:8bdfeed0-1cbe-44eb-a097-47bdddc32767 -->
   
   
   [](8bdfeed0-1cbe-44eb-a097-47bdddc32767)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to