mistercrunch opened a new pull request, #34675:
URL: https://github.com/apache/superset/pull/34675
Fixed ag-grid theming regression where SQL Lab result tables displayed
black text on white background in dark mode. Created centralized
ThemedAgGridReact component in @superset-ui/core that properly applies
Superset theme colors using ag-grid v34's JavaScript theming API.
Changes:
- Created ThemedAgGridReact component in @superset-ui/core
- Moved ag-grid dependencies to @superset-ui/core package
- Updated GridTable to use ThemedAgGridReact
- Refactored plugin-chart-ag-grid-table to use shared component
- Applied consistent theme color mappings (colorFillTertiary for headers,
colorFillQuaternary for odd rows, colorSplit for borders)
- Fixed circular dependency by using relative imports
- Removed manual CSS imports that conflicted with ag-grid v34
- Removed all console.log statements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
