Antonio-RiveroMartnez commented on code in PR #34698:
URL: https://github.com/apache/superset/pull/34698#discussion_r2276785548
##########
superset-frontend/src/explore/components/ExploreViewContainer/index.jsx:
##########
@@ -541,7 +541,11 @@ function ExploreViewContainer(props) {
.map(message => {
const matchingLabels = controlsWithErrors
.filter(control => control.validationErrors?.includes(message))
- .map(control => control.label);
+ .map(control =>
+ typeof control.label === 'function'
Review Comment:
Probably a bigger change and not sure how feasible etc, but if a function we
should call the func before setting the label that way the component doesn't
need to be ware of this or any other type and instead "just render", but not
sure how worthy that approach would be assuming it would require bigger changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
