korbit-ai[bot] commented on code in PR #33791:
URL: https://github.com/apache/superset/pull/33791#discussion_r2277078531
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -251,6 +253,13 @@ function SelectPageSize({
const getNoResultsMessage = (filter: string) =>
filter ? t('No matching records found') : t('No records found');
+const sanitizeHtmlValue = (value: DataRecordValue): DataRecordValue => {
+ if (typeof value === 'string' && isProbablyHTML(value)) {
+ return removeHTMLTags(value);
+ }
Review Comment:
Agreed - moving sanitizeHtmlValue to the HTML utils module would improve
reusability. That's a better place for HTML sanitization utilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
