michael-s-molina commented on code in PR #34526:
URL: https://github.com/apache/superset/pull/34526#discussion_r2279135702
##########
superset-frontend/package.json:
##########
@@ -342,6 +342,7 @@
"peerDependencies": {
"ace-builds": "^1.41.0",
"core-js": "^3.38.1",
+ "handlebars": "^4.7.8",
Review Comment:
@mistercrunch Given that `handlebars` is being used by Superset and not only
by the plugin anymore, I think we should declare it as a dependency of Superset
and make it a peer dependency in the plugin. The current form is problematic as
the plugin might not be installed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
