kasiazjc commented on PR #34642:
URL: https://github.com/apache/superset/pull/34642#issuecomment-3196150039
@mistercrunch one note I have is about the "validate" button, two ways we
can go about it:
1. in general there should be one primary button in a modal/page, and in
here we already have "save", which makes sense as it is the final action. I
would make "validate" button a ghost button with play icon, so that it is still
visible, but doesn't disrupt the hierarchy.
2. Perfect case scenario would be to match validation patterns we have in
dataset modal, so small play button at the top (it is primary in those cases,
but it does not disrupt the hierarchy and is separated by the sql panel).
For consistency I would go with the current implementation that we have
already, especially as it leaves a lot of space for the more in depth metadata
descriptions + in terms of information architecture - you run at the top and
get feedback at the bottom. I know that it is to save space, but it feels
counter intuitive to have button on the right and in the same line feedback on
the left
<img width="367" height="338" alt="image"
src="https://github.com/user-attachments/assets/e2ac94af-15a2-45eb-9c5c-c807bf6215d7";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
