justinpark opened a new pull request, #34767:
URL: https://github.com/apache/superset/pull/34767

   ### SUMMARY
   Previously, the resizable sidebar and react-splitter were managed 
separately, but now panel resizing is handled through the splitter provided by 
Ant Design.
   Additionally, this commit updates the functionality so that, besides the 
existing menu, user can collapse or expand the panel using the buttons provided 
by the splitter.
   
   Furthermore, since the results height is already calculated using 
[autosizer](https://github.com/apache/superset/pull/34683/files#diff-407b1e72d7f4462c85eca33d215cd9981b18db050f649dfaaac5748a262d09b8R701-R715),
 this commit removes related height calculation logic, making the size 
management simpler.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   After:
   
   
https://github.com/user-attachments/assets/57301174-489b-47ce-bac4-d9dd8626cdac
   
   
   ### TESTING INSTRUCTIONS
   Open SQL Lab and then adjust side panel and south panel sizes
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to