sadpandajoe commented on code in PR #34769:
URL: https://github.com/apache/superset/pull/34769#discussion_r2287111493
##########
tests/integration_tests/charts/api_tests.py:
##########
@@ -1076,6 +1076,55 @@ def test_get_chart_not_found(self):
rv = self.get_assert_metric(uri, "get")
assert rv.status_code == 404
+ def test_slice_get_by_id(self):
Review Comment:
Are you saying combine the id ones together and the uuid ones together? I
normally prefer them separate in case if one use case fails and the other one
passes, but can see that the uuid one might not actually be testing anything if
we aren't in the if statement clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
