Re: [PR] feat: refactor modals to use consistent design patterns [superset]

[via GitHub]

kasiazjc commented on PR #34711:
URL: https://github.com/apache/superset/pull/34711#issuecomment-3206263542

   > 1. We don't always use the green check mark in the modals - we do that in 
Alerts & Reports but not in DB connection advanced settings (where everything 
is not optional). @kasiazjc in the like dashboard properties where some 
sections have required fields and others don't, should we only show the green 
check in sections with required sections?
   
   I would use check/x for sections, it will be easier to spot what is missing. 
It would be great if we could add a rule, that all required fields should have 
red `*` next to the label across the app - not sure if it is something we can 
do easily @mistercrunch ? 
   
   > 4. Dashboard Name hint text needs updating, or just remove it to match the 
Chart name field
   > 
   > <img alt="image" width="542" height="426" 
src="https://private-user-images.githubusercontent.com/10627051/479825735-99dbe7f3-364e-4f33-87ba-dfbf4188e63d.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTU2OTUxMTMsIm5iZiI6MTc1NTY5NDgxMywicGF0aCI6Ii8xMDYyNzA1MS80Nzk4MjU3MzUtOTlkYmU3ZjMtMzY0ZS00ZjMzLTg3YmEtZGZiZjQxODhlNjNkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA4MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwODIwVDEzMDAxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRhNjg3MjQxMWJmZGQzN2VjZGZlMDc4MWQxYjkxNzQ2NzcyNGZhYTgzYzYwZTk3MjQwOTc5YzllNDkwMjUyOWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.dYN9MlnkRq59mKc1M9FnJLEnPd1Ea50kLYLixzlvj1g";>
   
   In general I would avoid using metadata for basic hints - can we move it to 
the field as placeholder? @mistercrunch 
   
   One more note from me (for now) is that errors should be shown in metadata 
in red under the field. This warning should show up next to the label. 
   <img width="858" height="216" alt="image" 
src="https://github.com/user-attachments/assets/4392ba2c-8911-4900-a963-08894b5ec4b4";
 />
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org