mistercrunch commented on code in PR #34766:
URL: https://github.com/apache/superset/pull/34766#discussion_r2289306371
##########
superset/models/core.py:
##########
@@ -864,6 +864,45 @@ def get_all_view_names_in_schema(
except Exception as ex:
raise self.db_engine_spec.get_dbapi_mapped_exception(ex) from ex
+ @cache_util.memoized_func(
+
key="db:{self.id}:catalog:{catalog}:schema:{schema}:materialized_view_list",
+ cache=cache_manager.cache,
+ )
+ def get_all_materialized_view_names_in_schema(
+ self,
+ catalog: str | None,
+ schema: str,
+ ) -> set[tuple[str, str, str | None]]:
Review Comment:
go fancy types wit a named tuple?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
