sadpandajoe commented on code in PR #34780:
URL: https://github.com/apache/superset/pull/34780#discussion_r2289461729
##########
tests/unit_tests/db_engine_specs/test_singlestore.py:
##########
@@ -95,18 +95,22 @@ def test_get_schema_from_engine_params() -> None:
def test_adjust_engine_params() -> None:
+ from flask import current_app as app
+
adjusted = SingleStoreSpec.adjust_engine_params(
make_url("singlestoredb://user:password@host:5432/dev"),
{},
schema="pro d",
)
+
+ expected_version = app.config.get("VERSION_STRING", "dev")
Review Comment:
I could either grab this from our config file or I can mock this. Not sure
which path we prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
