justinpark opened a new pull request, #34781: URL: https://github.com/apache/superset/pull/34781
### SUMMARY In the previous #33522, the autocomplete function was set to be skipped before it was synced. In this commit, following the fix for the SQL editor flushing issue in #34720, this behavior has been reverted so that the autocomplete function works correctly. Additionally, an issue where deleted tabs were not removed upon refresh before they were synced to the server has been fixed. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF - autocomplete before: https://github.com/user-attachments/assets/d45df600-6507-46a1-a201-04873e47a204 after: https://github.com/user-attachments/assets/e9ad5f39-4bf7-43db-93a5-2d478f42c712| - close tabs before: https://github.com/user-attachments/assets/13f189ef-2886-47c1-8383-eb4a385d0762 after: https://github.com/user-attachments/assets/cf2d5a32-399b-441e-a27c-09fbe6891396 ### TESTING INSTRUCTIONS Open a new tab and type some keyword to check autocomplete and then close the tab and then refresh the page for deletion ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
