[PR] initial : bump webpack 5.2.1 to 5.2.2 to fix firefox crash [superset]

[via GitHub]

amaannawab923 opened a new pull request, #34791:
URL: https://github.com/apache/superset/pull/34791

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   Fixes: https://github.com/apache/superset/issues/34670
   
   ### SUMMARY
   
   This PR upgrades webpack-dev-server from 5.2.1 → 5.2.2 🚀 to resolve a 
runtime error that occurred in Firefox 🦊 when ResizeObserver warnings were 
emitted.
   
   ### Problem ❌
   
   In Firefox, ResizeObserver loop completed with undelivered notifications is 
dispatched as an ErrorEvent without a proper Error object.
   The dev server overlay attempted to unconditionally access error.stack, 
leading to:
   
   TypeError: can't access property "stack", error is undefined
   This caused the red error overlay 🟥 to crash instead of cleanly ignoring the 
warning.
   
   ### Fix ✅
   
   In webpack-dev-server@5.2.2, the overlay introduced a guard clause:
   
   if (!error && !message) {
     return;
   }
   
   if (error && error.stack && 
error.stack.includes("invokeGuardedCallbackDev")) {
     return;
   }
   handleError(error, message);
   
   
   By checking for the existence of error and error.stack before using them, 
the overlay now safely ignores ResizeObserver loop notifications in Firefox 🦊.
   
   ℹ️ The reason we did not notice this earlier is because ResizeObserver 
errors were already suppressed as part of this PR.
   https://github.com/apache/superset/pull/24868
   
   Impact 🌍
   Prevents spurious overlay crashes in Firefox 🦊
   Keeps normal runtime and compiler errors visible in the overlay 👀
   No functional changes outside of development 🛠️
   
   ### Changelog 📝
   
   ⬆️ Bump webpack-dev-server → 5.2.2
   
   🛡️ Fix overlay crash on Firefox ResizeObserver warnings
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org