Vicinius opened a new pull request, #34794: URL: https://github.com/apache/superset/pull/34794
### SUMMARY As of today, the mixed chart has no way to dash the time comparison line. This feature already works well on the regular time chart, but not on mixed chart because it was never implemented. This implements the time comparison function the same way it works on the regular line chart, but for mixed chart. It has been implemented both on timeseries A and B. This happens in the transformProps.ts file within the mixed chart plugin. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <img width="1914" height="918" alt="mixed charts time comparison working as line charts" src="https://github.com/user-attachments/assets/844a4bc0-d33c-4d63-a258-d9fd3722448b"; /> ### TESTING INSTRUCTIONS Create a mixed chart, enable the time comparison feature, set it to some time frame, see if the older timeline will be dashed ### ADDITIONAL INFORMATION - [x] Has associated issue: https://github.com/apache/superset/issues/34143 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
