Re: [PR] fix: Unexpected overflow ellipsis dots after status icon in Dashboard list [superset]

[via GitHub]

korbit-ai[bot] commented on code in PR #34798:
URL: https://github.com/apache/superset/pull/34798#discussion_r2291485241


##########
superset-frontend/packages/superset-ui-core/src/components/Table/index.tsx:
##########
@@ -180,6 +180,10 @@ const StyledTable = styled(AntTable as 
FC<AntTableProps>)<{ height?: number }>(
       text-overflow: ellipsis;
     }
 
+    td.ant-table-cell.no-ellipsis {
+      text-overflow: unset;
+    }

Review Comment:
   ### Incomplete overflow handling <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The text-overflow: unset property will remove ellipsis, but it doesn't 
guarantee the content will be fully visible if it overflows the cell.
   
   
   ###### Why this matters
   Content might still be hidden due to 'overflow: hidden' on parent elements, 
defeating the purpose of removing ellipsis to show full content.
   
   ###### Suggested change ∙ *Feature Preview*
   Add overflow properties to ensure content is fully visible:
   ```css
   td.ant-table-cell.no-ellipsis {
         text-overflow: unset;
         overflow: visible;
         white-space: normal;
   }
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f852677d-78dd-401a-8f39-89780a4e54dc/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f852677d-78dd-401a-8f39-89780a4e54dc?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f852677d-78dd-401a-8f39-89780a4e54dc?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f852677d-78dd-401a-8f39-89780a4e54dc?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/f852677d-78dd-401a-8f39-89780a4e54dc)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:916806de-e6b5-46d1-8438-606552f0f4d0 -->
   
   
   [](916806de-e6b5-46d1-8438-606552f0f4d0)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org