Copilot commented on code in PR #34799:
URL: https://github.com/apache/superset/pull/34799#discussion_r2291532398
##########
superset-frontend/plugins/plugin-chart-table/src/DataTable/DataTable.tsx:
##########
@@ -451,29 +451,21 @@ export default typedMemo(function DataTable<D extends
object>({
{hasGlobalControl ? (
<div ref={globalControlRef} className="form-inline dt-controls">
<StyledRow className="row">
- <div
- className={renderTimeComparisonDropdown ? 'col-sm-4' :
'col-sm-5'}
- >
- {hasPagination ? (
- <SelectPageSize
- total={resultsSize}
- current={resultCurrentPageSize}
- options={pageSizeOptions}
- selectRenderer={
- typeof selectPageSize === 'boolean'
- ? undefined
- : selectPageSize
- }
- onChange={setPageSize}
- />
- ) : null}
- </div>
{searchInput ? (
- <StyledSpace
- className={
- renderTimeComparisonDropdown ? 'col-sm-7' : 'col-sm-8'
- }
- >
+ <StyledSpace size="middle">
Review Comment:
The conditional rendering structure creates asymmetric layout. When
`searchInput` is falsy, pagination controls won't be rendered at all since
they're now nested inside the searchInput condition. Consider restructuring to
ensure pagination controls are always available when `hasPagination` is true,
regardless of search input state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
