justinpark opened a new pull request, #34808:
URL: https://github.com/apache/superset/pull/34808

   ### SUMMARY
   Currently, to read the column description information and recognize the data 
format, we execute a query with a limit size of 1 to access the records 
contained in the column. This is not an issue for most data engines, but in the 
case of the materialized view DB used internally at Airbnb, such a limit 1 
query causes problems. (TL;DR: Since there are many possible data sources for 
the given dimension column, a query like `SELECT dim_country FROM all LIMIT 1` 
cannot be executed.)
   To solve this issue, this commit made it possible to override this limit 
size in the db_engine_spec.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A
   
   ### TESTING INSTRUCTIONS
   specs are added
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to