kasiazjc commented on PR #34790: URL: https://github.com/apache/superset/pull/34790#issuecomment-3213602559
> @kasiazjc What do you think about the scrollable container? After which point we should make it scroll instead of grow? looks great! in general for the popover I think it will be displayed bottom or top of the trigger icon, based on the scroll location of the user right? I would just make sure that it always is displayed at the top of the other components (likefilter bar or nav bar) and there is top and bottom margin of 36px so that it doesn't touch the window (browser) edges. If the height is reached enable internal scroll -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
