mistercrunch commented on code in PR #33392:
URL: https://github.com/apache/superset/pull/33392#discussion_r2294967499
##########
superset-frontend/src/explore/components/PropertiesModal/index.tsx:
##########
@@ -179,20 +179,15 @@ function PropertiesModal({
}
try {
- const res = await SupersetClient.put({
+ let res = await SupersetClient.put({
endpoint: `/api/v1/chart/${slice.slice_id}`,
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify(payload),
});
- // update the redux state
- const updatedChart = {
- ...payload,
- ...res.json.result,
- tags,
- id: slice.slice_id,
- owners: selectedOwners,
- };
- onSave(updatedChart);
+ res = await SupersetClient.get({
+ endpoint: `/api/v1/chart/${slice.slice_id}`,
+ });
+ onSave(res.json.result);
Review Comment:
related: https://chatgpt.com/share/68a90a13-5390-8010-b149-6a87d0014de3
Personally would say: got for it, make it such that all 3 PUT/POST/GET all
return the same schema as per best practices. If something break, a test should
fail or we'll know soon enough.
Might be good to grep/search or add Claude Code or AI to do a deep search in
the repo to confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
