dankor commented on code in PR #34836:
URL: https://github.com/apache/superset/pull/34836#discussion_r2300308236
##########
superset/charts/schemas.py:
##########
@@ -1130,8 +1130,9 @@ class AnnotationLayerSchema(Schema):
class ChartDataDatasourceSchema(Schema):
description = "Chart datasource"
- id = fields.Integer(
- metadata={"description": "Datasource id"},
+ # Coudn't find a better way to mix uuid and id
+ id = fields.Raw(
Review Comment:
@mistercrunch Thanks! I reworked.
Please take another look, included `marshmallow-union` dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
