dosubot[bot] commented on issue #34856:
URL: https://github.com/apache/superset/issues/34856#issuecomment-3224414027

   <!-- Greeting -->
   Hi @sofiankhalfi-kosmos! I'm [Dosu](https://go.dosu.dev/dosubot) and I’m 
helping the superset team.
   
   <!-- Answer -->
   Yes, recent changes in Superset's SQL dialect handling could be causing 
incompatibility with Pinot 1.0.0. Superset generates Pinot queries using the 
MySQL dialect via the sqlglot library, and recent updates to sqlglot or 
Superset's dialect mapping may produce SQL syntax (like backticks or tabs) that 
Pinot 1.0.0 can't parse. The Pinot engine spec itself hasn't changed in a way 
that would break compatibility, but the underlying SQL generator likely has. 
This means the issue is probably due to how Superset (and sqlglot) now formats 
SQL for Pinot, not a direct change in Pinot-specific logic. If you need to 
restore compatibility, you may need to adjust the SQLGLOT_DIALECTS_EXTENSIONS 
config or patch the dialect mapping to avoid MySQL-specific syntax for Pinot 
1.0.0. More details on the dialect mapping and recent changes can be found 
[here](https://github.com/apache/superset/pull/30560) and 
[here](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/
 sql/parse.py).
   
   
   <!-- Dosu Comment Footer -->
   *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*
   
   ---
   <sup>How did I do? 
[Good](https://app.dosu.dev/response-feedback/bbdd28ae-89df-4ab8-a35e-7b85056dd648?feedback_type=great_response)
 | 
[Irrelevant](https://app.dosu.dev/response-feedback/bbdd28ae-89df-4ab8-a35e-7b85056dd648?feedback_type=irrelevant_answer)
 | 
[Incorrect](https://app.dosu.dev/response-feedback/bbdd28ae-89df-4ab8-a35e-7b85056dd648?feedback_type=incorrect_sources)
 | 
[Verbose](https://app.dosu.dev/response-feedback/bbdd28ae-89df-4ab8-a35e-7b85056dd648?feedback_type=too_verbose)
 | 
[Hallucination](https://app.dosu.dev/response-feedback/bbdd28ae-89df-4ab8-a35e-7b85056dd648?feedback_type=hallucination)
 | [Report 
šŸ›](https://app.dosu.dev/response-feedback/bbdd28ae-89df-4ab8-a35e-7b85056dd648?feedback_type=bug_report)
 | 
[Other](https://app.dosu.dev/response-feedback/bbdd28ae-89df-4ab8-a35e-7b85056dd648?feedback_type=other)</sup>&nbsp;&nbsp;[![Chat
 with 
Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=githu
 b)&nbsp;[![Join 
Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share
 on 
X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/34856)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to